Re: Alpha4 release blockers (was Re: wrapping up this CommitFest)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Andres Freund <andres@anarazel.de>

Cc: pgsql-hackers@postgresql.org, Peter Eisentraut <peter_e@gmx.net>, Rémi Zara <remi_zara@mac.com>, Stefan Huehner <stefan@huehner.org>

Date: 2011-03-06T17:16:48Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Further refine patch for commenting operator implementation functions.
- 908ab8028640 9.1.0 cited
Fix citext's upgrade-from-unpackaged script to set its collation correctly.
- 94be9e3f0ca9 9.1.0 cited
Mark operator implementation functions as such in their comments.
- 94133a935414 9.1.0 cited
Add KNNGIST support to contrib/btree_gist.
- 8436489c81c2 9.1.0 cited
Fix plpython breakage detected on certain Fedora machines on buildfarm.
- 4c966d920fb7 9.1.0 cited

Andres Freund <andres@anarazel.de> writes:
> -		fmgr_info_collation(irel->rd_index->indcollation.values[attnum-1],
> +		fmgr_info_collation(irel->rd_indcollation[attnum-1],
>  							locinfo);

BTW, I went ahead and committed this part, since the bug and the fix are
clear.  I'm still not thrilled with the plan of sprinkling the code with
random fmgr_info_collation() calls to make up for the lack of a sane
default.  IMO, that *is* a default, just a badly implemented one.

			regards, tom lane