Horton

Re: [PATCH] remove deprecated v8.2 containment operators

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Tom Lane <tgl@sss.pgh.pa.us>, Stephen Frost <sfrost@snowman.net>, Ian Lawrence Barwick <barwick@gmail.com>, pgsql-hackers@postgresql.org
Date: 2020-11-03T09:47:14Z
Lists: pgsql-hackers 
On 2020-10-27 04:25, Justin Pryzby wrote:
> Forking this thread:
> https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4def@iki.fi
> 
> They have been deprecated for a Long Time, so finally remove them for v14.
> Four fewer exclamation marks makes the documentation less exciting, which is a
> good thing.

I have committed the parts that remove the built-in geometry operators 
and the related regression test changes.

The changes to the contrib modules appear to be incomplete in some ways. 
  In cube, hstore, and seg, there are no changes to the extension 
scripts to remove the operators.  All you're doing is changing the C 
code to no longer recognize the strategy, but that doesn't explain what 
will happen if the operator is still used.  In intarray, by contrast, 
you're editing an existing extension script, but that should be done by 
an upgrade script instead.

Commits

  1. Doc: remove obsolete entries in table of BRIN strategy numbers.

  2. Remove deprecated containment operators for contrib types.

  3. Remove unused and deprecated strategy numbers from BRIN code

  4. Remove code handling removed deprecated containment operators

  5. Remove deprecated containment operators for built-in types

  6. Remove use of deprecated containment operators in tests