Re: More const-marking cleanup

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2025-12-05T16:20:50Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix some cases of indirectly casting away const.
- de77775a7b50 18.4 landed
- cc9c22a5160a 15.18 landed
- a56a70141e09 17.10 landed
- 244c047205bb 14.23 landed
- 0969bfd0db86 16.14 landed
- 8f1791c61836 19 (unreleased) landed
Fix another case of indirectly casting away const.
- 9f7565c6c2d4 19 (unreleased) landed
ecpg: refactor to eliminate cast-away-const in find_variable().
- 4eda42e8bdf5 19 (unreleased) landed

Bertrand Drouvot <bertranddrouvot.pg@gmail.com> writes:
> On Fri, Dec 05, 2025 at 09:47:56AM -0500, Tom Lane wrote:
>> Cool, how'd you find these?

> With the help of a coccinelle script. Will polish and share.

Ah.  Your script didn't notice the need for const'ification of
additional variables in map_locale() :-(.  I fixed that and
pushed everything except the ecpg/preproc/variable.c changes,
which I'm not too comfortable about yet.  (The code coverage
report shows that large chunks of those functions are untested,
so I wonder if they worked before let alone after.)

			regards, tom lane