Horton

Re: MSVC Build support with visual studio 2019

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juanjo Santamaria Flecha <juanjo.santamaria@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>
Date: 2019-05-21T21:35:24Z
Lists: pgsql-hackers 
I have gone through path '0001-Support-building-with-visual-studio-2019.patch' only, but I am sure some comments will also apply to back branches.

1. The VisualStudioVersion value looks odd:

+	$self->{VisualStudioVersion}        = '16.0.32.32432';

Are you using a pre-release version [1]?

2. There is a typo: s/stuido/studio/:

+	# The major visual stuido that is suppored has nmake version >= 14.20 and < 15.

There is something in the current code that I think should be also updated. The code for _GetVisualStudioVersion contains:

  if ($major > 14)
 	{
 	carp
 	 "The determined version of Visual Studio is newer than the latest supported version. Returning the latest supported version instead.";
 	return '14.00';
 	}

Shouldn't the returned value be '14.20' for Visual Studio 2019?

Regards,

Juan José Santamaría Flecha

[1] https://docs.microsoft.com/en-us/visualstudio/releases/2019/history#release-dates-and-build-numbers

Commits

  1. Add support for Visual Studio 2019 in build scripts

  2. Support building with Visual Studio 2017

  3. Require C99 (and thus MSCV 2013 upwards).