Re[2]: BUG #15724: Can't create foreign table as partition
Stepan Yankevych <stepya@ukr.net>
From: Stepan Yankevych <stepya@ukr.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-03-29T16:25:42Z
Lists: pgsql-bugs
>> I'm not sure that just forcing the case to be a no-op is wise. >> What if the index is supposed to be UNIQUE?Anyway it would be better to have no-op in 11.3 than having it not working. We just can put comment in the doc like. Foreign Server should take care about indexing foreign table as partition. --- Original message --- From: "Tom Lane" <tgl@sss.pgh.pa.us> Date: 29 March 2019, 16:01:41 Alvaro Herrera <alvherre@2ndquadrant.com> writes: > On 2019-Mar-29, PG Bug reporting form wrote: >> SQL Error [42809]: ERROR: cannot create index on foreign table "msg_json" > Ah, this is because we try to propagate the index to the partition, > which appears to be less than desirable. Maybe this patch fixes it? I > have not tested it, only verified that it compiles. Really, what *ought* to happen in such a case is that the FDW gets told about the command and has the opportunity to try to do something corresponding to making an index. But that smells like a new feature rather than a bug fix. I'm not sure that just forcing the case to be a no-op is wise. What if the index is supposed to be UNIQUE? regards, tom lane
Commits
-
Fix partitioned index creation with foreign partitions
- 9653ca2197e2 11.5 landed
- 55ed3defc966 12.0 landed
-
Doc: Update documentation on partitioning vs. foreign tables.
- 7338ed28e2ec 11.3 landed
- 3e6b0c472942 12.0 landed