Horton

Re: Improving psql's \password command

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-11T16:11:51Z
Lists: pgsql-hackers 
"Bossart, Nathan" <bossartn@amazon.com> writes:
> On 10/29/21, 5:07 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
>> I was afraid somebody would say that.  I have looked at it, but AFAICS
>> we'd have to duplicate all of sprompt.c and nearly all of pg_get_line.c
>> in order to tie it into psql's SIGINT infrastructure, since we wouldn't
>> dare enable the signal handler except during the innermost fgets() call,
>> and if we did get a signal we'd still need to clean up the terminal echo
>> state, so we couldn't just longjmp out of simple_prompt().  The
>> cost/benefit ratio of that doesn't look very good.

> Hm.  Is it really necessary to duplicate all of sprompt.c and
> pg_get_line.c?  Would it be possible to teach the existing functions
> how to optionally enable SIGINT handling instead?  I wouldn't mind
> trying my hand at this if it seems like a reasonable approach.

It seems to me it'd overcomplicate simple_prompt's API for one use-case
... but if you want to try it, step right up.  (I suppose some of that
objection could be overcome by making simple_prompt into a wrapper
around another function not_so_simple_prompt.)

			regards, tom lane

Commits

  1. pg_receivewal, pg_recvlogical: allow canceling initial password prompt.

  2. Allow psql's other uses of simple_prompt() to be interrupted by ^C.

  3. Provide a variant of simple_prompt() that can be interrupted by ^C.

  4. Make psql's \password default to CURRENT_USER, not PQuser(conn).