Re: Offline enabling/disabling of data checksums
Michael Banck <michael.banck@credativ.de>
From: Michael Banck <michael.banck@credativ.de>
To: Magnus Hagander <magnus@hagander.net>, Sergei Kornilov <sk@zsrv.org>
Cc: Michael Paquier <michael@paquier.xyz>, Fabien COELHO
<coelho@cri.ensmp.fr>, PostgreSQL Developers
<pgsql-hackers@lists.postgresql.org>
Date: 2019-03-15T10:41:55Z
Lists: pgsql-hackers
Hi, Am Mittwoch, den 13.03.2019, 12:24 +0100 schrieb Magnus Hagander: > On Wed, Mar 13, 2019 at 11:54 AM Sergei Kornilov <sk@zsrv.org> wrote: > > One new question from me: how about replication? > > Case: primary+replica, we shut down primary and enable checksum, and > > "started streaming WAL from primary" without any issue. I have > > master with checksums, but replica without. > > Or cluster with checksums, then disable checksums on primary, but > > standby think we have checksums. > > Enabling or disabling the checksums offline on the master quite > clearly requires a rebuild of the standby, there is no other way (this > is one of the reasons for the online enabling in that patch, so I > still hope we can get that done -- but not for this version). > > You would have the same with PITR backups for example. I'd like to get back to PITR. I thought about this a bit and actually I think PITR might be fine in the sense that if you enabled or disabled the cluster after the last basebackup and then do PITR with the avaiable WAL beyond that, you would get a working cluster, just with the checksum state the cluster had at the time of the basebackup. I think that would be entirely accetable, so long as nothing else breaks? I made some quick tests and did see no errors, but maybe I am missing something? > And especially if you have some tool that does block or segment level > differential. This might be the case, but not sure if PostgreSQL core must worry about it? Obviously the documentation must be made explicit about these kinds of cases. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz
Commits
-
Reorganize Notes section in documentation of pg_checksums
- a7cc52370b2b 12.0 landed
-
Add option -N/--no-sync to pg_checksums
- e0090c869008 12.0 landed
-
Add options to enable and disable checksums in pg_checksums
- ed308d783790 12.0 landed
-
Refactor more code logic to update the control file
- 8b938d36f744 12.0 landed
-
Rename pg_verify_checksums to pg_checksums
- 6dd263cfaa84 12.0 landed
-
Fix cross-version compatibility checks of pg_verify_checksums
- 501f58359b59 11.3 landed
- c9ae7f704c67 12.0 landed
-
Add routine able to update the control file to src/common/
- ce6afc6823fb 12.0 landed