Re: CPU costs of random_zipfian in pgbench
gkokolatos@pm.me
From: Georgios Kokolatos <gkokolatos@pm.me>
To: pgsql-hackers@lists.postgresql.org
Cc: Fabien Coelho <postgresql.org@coelho.net>
Date: 2019-03-13T08:55:10Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation: not tested For whatever it is worth, the patch looks good to me. A minor nitpick would be to use a verb in the part: `cost when the parameter in (0, 1)` maybe: `cost when the parameter's value is in (0, 1)` or similar. Apart from that, I would suggest it that the patch could be moved to Waiting for Author state.
Commits
-
Remove now-unnecessary thread pointer arguments in pgbench.
- d8c0bd9fefa9 12.0 landed
-
Restrict pgbench's zipfian parameter to ensure good performance.
- 26a76cb64072 12.0 landed