Horton

Re: Progress reporting for pg_verify_checksums

Michael Banck <michael.banck@credativ.de>

View thread View on postgr.es
From: Michael Banck <michael.banck@credativ.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>, Bernd Helmle <mailings@oopsware.de>
Cc: Michael Paquier <michael@paquier.xyz>, Fabien COELHO <coelho@cri.ensmp.fr>, Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-02-18T16:44:50Z
Lists: pgsql-hackers

Attachments

Hi,

Am Montag, den 18.02.2019, 13:42 -0300 schrieb Alvaro Herrera:
> On 2019-Feb-18, Bernd Helmle wrote:
> 
> > Am Montag, den 18.02.2019, 16:52 +0100 schrieb Michael Banck:
> > > > Surely we know at that point whether this first scan is needed, and
> > > > we can skip it if not?
> > > 
> > > Yeah - new patch attached.
> > 
> > Maybe i'm wrong, but my thought is that this breaks the SIGUSR1
> > business, since there seems no code path which calculates total_size in
> > this case?
> 
> Oh, yeah, it does.  In that case, a comment explaining that is needed.

New patch attached.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums