Horton

Re: Progress reporting for pg_verify_checksums

Michael Banck <michael.banck@credativ.de>

View thread View on postgr.es
From: Michael Banck <michael.banck@credativ.de>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, Fabien COELHO <coelho@cri.ensmp.fr>, Thomas Munro <thomas.munro@enterprisedb.com>, Bernd Helmle <bernd.helmle@credativ.de>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-02-18T15:52:48Z
Lists: pgsql-hackers

Attachments

Hi,

Am Montag, den 18.02.2019, 11:18 -0300 schrieb Alvaro Herrera:
> On 2019-Feb-17, Michael Banck wrote:
> > +	/*
> > +	 * As progress status information may be requested, we need to scan the
> > +	 * directory tree(s) twice, once to get the idea how much data we need to
> > +	 * scan and finally to do the real legwork.
> > +	 */
> > +	total_size = scan_directory(DataDir, "global", true);
> > +	total_size += scan_directory(DataDir, "base", true);
> > +	total_size += scan_directory(DataDir, "pg_tblspc", true);
> 
> Surely we know at that point whether this first scan is needed, and we
> can skip it if not?

Yeah - new patch attached.


Michael 

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz

Commits

  1. Add progress reporting to pg_checksums

  2. Fix thinko when bumping on temporary directories in pg_verify_checksums

  3. Fix thinko when bumping on temporary directories in pg_checksums