Re: REINDEX CONCURRENTLY 2.0
Sergei Kornilov <sk@zsrv.org>
From: Sergei Kornilov <sk@zsrv.org>
To: pgsql-hackers@lists.postgresql.org
Cc: Peter Eisentraut <peter@eisentraut.org>
Date: 2019-02-07T14:28:05Z
Lists: pgsql-hackers
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: tested, passed Hello Sorry for late response. I review latest patch version. I didn't found any new behavior bugs. reindex concurrenlty can be in deadlock with another reindex concurrently (or manual vacuum (maybe with wraparound autovacuum) or create index concurrently on same table). But i think this is not issue for this feature, two create index concurrently can be in deadlock too. Just one small note for documentation: > +Indexes: > + "idx" btree (col) > + "idx_cct" btree (col) INVALID Second index should be idx_ccnew (or idx_ccold), right? Code looks good for me. regards, Sergei
Commits
-
Prevent reindex of invalid indexes on TOAST tables
- 8bca5f93547c 12.3 landed
- 61d7c7bce368 13.0 landed
-
Rework handling of invalid indexes with REINDEX CONCURRENTLY
- a6dcf9df4d91 12.0 landed
-
Split builtins.h to a new header ruleutils.h
- 7b1c2a0f2066 9.5.0 cited