Horton

Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Maxim Orlov <orlovmg@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Michael Paquier <michael@paquier.xyz>
Date: 2024-08-20T15:04:07Z
Lists: pgsql-hackers 
Maxim Orlov <orlovmg@gmail.com> writes:
> So, my point here: installcheck-world doesn't
> work on the current master branch until I explicitly install
> injection_points extension.  In my view, it's a bit wired, since
> neither test_decoding, pg_stat_statements or pg_prewarm demand it.

Ugh.  The basic issue here is that "make install-world" doesn't
install anything from underneath src/test/modules, which I recall
as being an intentional decision.  Rather than poking a hole in
that policy for injection_points, I wonder if we should move it
to contrib.

			regards, tom lane

Commits

  1. Check availability of module injection_points in TAP tests

  2. Avoid installcheck failure in TAP tests using injection_points

  3. Simplify makefiles exporting twice enable_injection_points