Re: PGOPTIONS="-fh" make check gets stuck since Postgres 11
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
Melanie Plageman <melanieplageman@gmail.com>,
Thomas Munro <thomas.munro@gmail.com>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-07-10T13:45:47Z
Lists: pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes: > On Wed, Jul 10, 2019 at 12:51:28PM +0530, Amit Kapila wrote: >> It would be good if we can come up with something like that. It will >> be helpful for zheap, where in some cases we get different row >> ordering due to in-place updates. As of now, we try to add Order By >> or do some extra magic to get consistent row ordering. > That was an issue for me as well when working with Postgres-XC when > the row ordering was not guaranteed depending on the number of nodes > (speaking of which Greenplum has the same issues, no?). Adding ORDER > BY clauses to a set of tests may make sense, but then this may impact > the plans generated for some of them.. Yeah, I do not want to get into a situation where we can't test queries that lack ORDER BY. Also, the fact that tableam X doesn't reproduce heap's row ordering is not a good reason to relax the strength of the tests for heap. So I'm wondering about some postprocessing that we could optionally apply. Perhaps the tools Melanie mentions could help. regards, tom lane
Commits
-
Force hash joins to be enabled in the hash join regression tests.
- 3955c50f3762 11.5 landed
- cba0fe024e35 13.0 landed
- 5526baf54902 12.0 landed