Re: reindexdb & clusterdb broken against pre-7.3 servers

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Andrew Dunstan <andrew.dunstan@2ndquadrant.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, noah@leadboat.com
Date: 2019-05-06T15:34:24Z
Lists: pgsql-hackers
Julien Rouhaud <rjuju123@gmail.com> writes:
> WFM.  Updated patch attached, I also removed another similar chunk in
> the same file while at it.

Uh, that looks backwards:

@@ -146,10 +146,6 @@ connectDatabase(const char *dbname, const char *pghost,
 		exit(1);
 	}
 
-	if (PQserverVersion(conn) >= 70300)
-		PQclear(executeQuery(conn, ALWAYS_SECURE_SEARCH_PATH_SQL,
-							 progname, echo));
-
 	return conn;
 }
 

			regards, tom lane



Commits

  1. Remove some code related to 7.3 and older servers from tools of src/bin/