Re: Progress reporting for pg_verify_checksums
Michael Banck <michael.banck@credativ.de>
From: Michael Banck <michael.banck@credativ.de>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, Bernd Helmle <bernd.helmle@credativ.de>, Pg Hackers <pgsql-hackers@postgresql.org>, Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2018-12-25T16:29:06Z
Lists: pgsql-hackers
Attachments
- pg_verify_checksums_progress_V6.patch (text/x-patch) patch
Hi, Am Dienstag, den 25.12.2018, 12:12 +0100 schrieb Fabien COELHO: > > Given the speed of verifying checksums and its storage-oriented status, I > > also still think that a (possibly fractional) MB (1,000,000 bytes), or even > > GB, is the right unit to use for reporting this progress. On my laptop (SSD), > > verifying runs at least at 1.26 GB/s (on one small test), there is no point > > in displaying kilobytes progress. > > Obviously the file is cached by the system at such speed, but still most > disks should provides dozens of MB per second of read bandwidth. If GB is > used, it should use fractional display (eg 1.25 GB) though. I think MB indeed makes more sense than kB, so I have changed that now in V7, per attached. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.banck@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz
Commits
-
Add progress reporting to pg_checksums
- 280e5f14056b 12.0 landed
-
Fix thinko when bumping on temporary directories in pg_verify_checksums
- da453004869d 11.3 landed
-
Fix thinko when bumping on temporary directories in pg_checksums
- 6eebfdc38b17 12.0 landed