Horton

Thread

Commits

  1. Doc: fix incorrect example of collecting arguments with fmgr macros.

  1. Error in example

    The Post Office <noreply@postgresql.org> — 2018-12-19T12:33:53Z

    The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/10/spi-examples.html
Description:

Dear, 

In the example of how to use SPI in the following link
https://www.postgresql.org/docs/10/spi-examples.html

The parameters numbers in the follow lines are wrong. 

    / * Convert a text object to a C string * /
    command = text_to_cstring (PG_GETARG_TEXT_PP (1));
    cnt = PG_GETARG_INT32 (2);

They should be as follow:

    / * Convert a text object to a C string * /
    command = text_to_cstring (PG_GETARG_TEXT_PP (0));
    cnt = PG_GETARG_INT32 (1);

Best regards,
Gláucio

  2. Re: Error in example

    Tom Lane <tgl@sss.pgh.pa.us> — 2018-12-19T15:07:51Z

    =?utf-8?q?PG_Doc_comments_form?= <noreply@postgresql.org> writes:
> In the example of how to use SPI in the following link
> https://www.postgresql.org/docs/10/spi-examples.html
> The parameters numbers in the follow lines are wrong. 
>     / * Convert a text object to a C string * /
>     command = text_to_cstring (PG_GETARG_TEXT_PP (1));
>     cnt = PG_GETARG_INT32 (2);

You're right.  Will fix, thanks for the report!

			regards, tom lane