Horton

Re: BUG #15892: URGENT: Using an ICU collation in a primary key column breaks ILIKE query

Artur Zakirov <a.zakirov@postgrespro.ru>

View thread View on postgr.es
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Verite <daniel@manitou-mail.org>, James Inform <james.inform@pharmapp.de>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, pgsql-bugs@lists.postgresql.org
Date: 2019-08-12T09:12:13Z
Lists: pgsql-bugs 
On 12.08.2019 00:32, Tom Lane wrote:
> This topic seems to have slipped through the cracks, which is too bad
> because we surely could have gotten it fixed in time for last week's
> releases.  Oh well.

It is true. Also July commitfest had started by that time and it wasn't 
possible to add a new entry.

> I think Daniel's patch leaves more on the table than it needs to,
> and I don't like Arthur's patch because it's assuming more than it
> should about whether it's okay to pass a "char" to u_isalpha().
> I propose that we do things as attached, instead.

Yeah, u_isalpha() wasn't such good idea here. BTW Daniel already 
mentioned it above.

With the patch regression tests pass for me and James test case works 
fine as expected.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Commits

  1. Fix planner's test for case-foldable characters in ILIKE with ICU.