Horton

Thread

Commits

  1. Fix incorrect parameter name in a function header comment

  1. Fix typo in src/backend/utils/cache/lsyscache.c

    Hou, Zhijie <houzj.fnst@cn.fujitsu.com> — 2020-10-25T01:22:55Z

    Hi

I found the comment of function get_attgenerated(Oid relid, AttrNumber attnum) seems wrong.
It seems the function is given the attribute number not the name.

/*
  * get_attgenerated
  *
- *		Given the relation id and the attribute name,
+ *		Given the relation id and the attribute number,
  *		return the "attgenerated" field from the attribute relation.
  *
  *		Errors if not found.

Best regards,
houzj

  2. Re: Fix typo in src/backend/utils/cache/lsyscache.c

    David Rowley <dgrowleyml@gmail.com> — 2020-10-25T09:42:08Z

    On Sun, 25 Oct 2020 at 14:23, Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
> I found the comment of function get_attgenerated(Oid relid, AttrNumber attnum) seems wrong.
> It seems the function is given the attribute number not the name.

Thanks. Pushed.

David