Re: BUG #17512: Process running query fails with SIGSEV - nodeMemoize.c:349

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Aleš Zelený <zeleny.ales@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-06-07T23:43:01Z
Lists: pgsql-bugs
David Rowley <dgrowleyml@gmail.com> writes:
> server closed the connection unexpectedly

Ugh.

> If I patch it with the attached rebustify_memoize_code.patch, I get:
> # explain analyze select * from t1 inner join t1 t2 on t1.a=t2.a where t1.a<=2;
> ERROR:  unable to find memoization table entry

> My thoughts are that we likely should make this code more robust,
> despite the bug not being related to a broken data type. I'm only just
> over the fence on that one though. Any thoughts?

Strong +1, but please s/unable to/could not/, per message style
guidelines.

			regards, tom lane



Commits

  1. Harden Memoization code against broken data types