Re: PostgreSQL crashes with SIGSEGV

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Aleksandr Parfenov <a.parfenov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org, Peter Geoghegan <pg@bowt.ie>
Date: 2018-01-17T19:23:18Z
Lists: pgsql-bugs, pgsql-hackers
Aleksandr Parfenov <a.parfenov@postgrespro.ru> writes:
> The new status of this patch is: Ready for Committer

I don't feel particularly comfortable committing a patch that
was clearly labeled as a rushed draft by its author.
Peter, where do you stand on this work?

In a quick look at the patches, WIP-kludge-fix.patch seems clearly
unacceptable for back-patching because it changes the signature and
behavior of ExecResetTupleTable, which external code might well be using.

			regards, tom lane


Commits

  1. Fix actual and potential double-frees around tuplesort usage.

  2. Allow the built-in ordered-set aggregates to share transition state.

  3. Avoid integer overflow while sifting-up a heap in tuplesort.c.

  4. Allow avoiding tuple copy within tuplesort_gettupleslot().

  5. Remove should_free arguments to tuplesort routines.

  6. Fix use-after-free around DISTINCT transition function calls.

  7. Reuse abbreviated keys in ordered [set] aggregates.