Re: Variable substitution in psql backtick expansion
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Robert Haas <robertmhaas@gmail.com>,
Pavel Stehule <pavel.stehule@gmail.com>,
Corey Huinker <corey.huinker@gmail.com>,
Daniel Verite <daniel@manitou-mail.org>,
PostgreSQL Developers <pgsql-hackers@postgresql.org>
Date: 2017-09-04T20:35:28Z
Lists: pgsql-hackers
Fabien COELHO <coelho@cri.ensmp.fr> writes: > I also like Daniel's idea to update formatting rules, eg following what is > done for environment variables and accepting that it won't fit in one page > anyway. Yeah. When you look at all three portions of the helpVariables output, it's clear that we have faced this issue multiple times before and not been too consistent about how we dealt with it. There are places that go over 80 columns; there are places that break the description into multiple lines (and some of those *also* exceed 80 columns); there are places that just shove the description onto the next line. I think we should go with Daniel's idea for all three parts. > I like trying to keep the 80 (or 88 it seems) columns limit if possible, > because my getting older eyes water on long lines. Me too :-(. Also, it seems like we should not assume that we have indefinite amounts of space in both dimensions. We've already accepted the need to page vertically, so let's run with that and try to hold the line on horizontal space. > In the documentation, I do not think that both SERVER_VERSION_NAME and > _NUM (or whatever their chosen name) deserve two independent explanations > with heavy repeats just one after the other, and being treated differently > from VERSION_*. I started with it that way, but it seemed pretty unreadable with the parenthetical examples added. And I think we need the examples, particularly the one pointing out that you might get something like "beta". > Seeing it as is, it calls for having "SERVER_VERSION" as well, but I'm not > sure of the better way to get it. I tried with "SELECT VERSION() AS > SERVER_VERSION \gset" but varnames are lowerized. The problem there is you can't get version() without an extra round trip to the server --- and an extra logged query --- which people are going to complain about. regards, tom lane
Commits
-
Add psql variables showing server version and psql version.
- a6c678f018d3 10.0 landed
- 9ae9d8c1549c 11.0 landed
-
Reformat psql's --help=variables output.
- 3955c8c4eda2 11.0 landed
-
Remove reinvention of stringify macro.
- cd6baed78150 10.0 landed
-
Allow psql variable substitution to occur in backtick command strings.
- f833c847b8fa 10.0 landed