Horton

Re: Include WAL in base backup

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: Stephen Frost <sfrost@snowman.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-01-20T15:28:25Z
Lists: pgsql-hackers 
Magnus Hagander <magnus@hagander.net> writes:
>> - Why not initialize logid and logseg like so?:
>> 
>>    int logid = startptr.xlogid;
>>    int logseg = startptr.xrecoff / XLogSegSize;
>> 
>> Then use those in your elog? Seems cleaner to me.

> Hmm. Yes. Agreed.

Marginal complaint here: int is the wrong type, I'm pretty sure.

			regards, tom lane