Re: compile warnings in CVS

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Neil Conway <nconway@klamath.dyndns.org>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2002-08-18T02:50:55Z
Lists: pgsql-hackers
I said:
> Another alternative is
> 	char *fmt = "%c";
> 	...
> 	strftime(..., fmt, ...);
> which I think will probably defeat gcc's check (haven't tried it
> though).

I tried this, and it did shut up the warning in my local copy of gcc.
So I committed it.

> Does anyone want to argue that %c is actually a bad choice?

This is still open to debate if anyone wants to make the case...

			regards, tom lane