Re: make check in contrib

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2011-04-25T15:22:49Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Apr 25, 2011 at 10:21 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Robert Haas <robertmhaas@gmail.com> writes:
>>> On Sun, Apr 24, 2011 at 7:18 PM, Peter Eisentraut <peter_e@gmx.net> wrote:
>>>> I noticed again that make check in contrib doesn't work, so here is a
>>>> patch to fix it.

>>> I think it might be more useful to have a check target that actually
>>> succeeds, even if it does nothing useful.

>> That argument seems a bit irrelevant to the proposed patch.

> How so?

The proposed patch is to fix it, not remove it.  Surely that's more
useful than a no-op target.

			regards, tom lane