Horton

Re: [PATCH] Fix overflow and underflow in regr_r2()

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Chengpeng Yan <chengpeng_yan@outlook.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-05-16T13:39:24Z
Lists: pgsql-hackers 
Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> Attached is a v2 patch with those changes, plus a little more tidying
> up of the regression tests.

LGTM.

> Arguably, this is a bug fix, but given the lack of prior complaints, I
> think we should apply this to HEAD only, like 6498287696d, meaning it
> will only appear in PG19.

Agreed on no back-patch.  It seems sensible to slip this into v19
rather than wait for v20, since the corresponding fix in corr()
is new as of 19.  But since that's a judgment call, maybe you should
get the concurrence of the RMT.

			regards, tom lane