Re: "debug_invalidate_system_caches_always" is too long
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-07-05T19:13:41Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes: > On Sun, Jul 04, 2021 at 04:27:13PM -0400, Tom Lane wrote: >> However, I think we should also give serious consideration to >> "debug_clobber_cache" or "debug_clobber_cache_always" for continuity >> with past practice (though it still feels like "always" is a good >> word to lose now). "debug_clobber_caches" is another reasonable >> variant. > https://en.wikipedia.org/wiki/Clobbering refers to cases where storage had no > changes to its accessibility but now contains different data. That doesn't > match InvalidateSystemCaches() especially well, so I think dropping that word > has been a good step. Some other shorter terms could be debug_flush_caches, > debug_rebuild_caches, or debug_expire_caches. (debug_caches is tempting, but > that may ensnare folks looking for extra logging rather than a big slowdown.) I like "debug_flush_caches" --- it's short and accurate. regards, tom lane
Commits
-
Rename debug_invalidate_system_caches_always to debug_discard_caches.
- d68a00391214 15.0 landed
- 6201fa3c166f 14.0 landed