Horton

Re: Speedup twophase transactions

Stas Kelvich <s.kelvich@postgrespro.ru>

View thread View on postgr.es
From: Stas Kelvich <s.kelvich@postgrespro.ru>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>, Jesper Pedersen <jesper.pedersen@redhat.com>, Robert Haas <robertmhaas@gmail.com>
Date: 2016-12-16T11:00:46Z
Lists: pgsql-hackers 
> On 27 Sep 2016, at 03:30, Michael Paquier <michael.paquier@gmail.com> wrote:
> 
> OK. I am marking this patch as returned with feedback then. Looking
> forward to seeing the next investigations.. At least this review has
> taught us one thing or two.

So, here is brand new implementation of the same thing.

Now instead of creating pgproc entry for prepared transaction during recovery,
I just store recptr/xid correspondence in separate 2L-list and deleting entries in that
list if redo process faced commit/abort. In case of checkpoint or end of recovery
transactions remaining in that list are dumped to files in pg_twophase.

Seems that current approach is way more simpler and patch has two times less
LOCs then previous one.

-- 
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Speedup 2PC recovery by skipping two phase state files in normal path

  2. Add tests for two-phase commit

  3. Improve grammar of message about two-phase state files.

  4. Speedup 2PC by skipping two phase state files in normal path