Re: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) (src/backend/utils/adt/jsonfuncs.c)

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2021-02-11T17:51:52Z
Lists: pgsql-hackers
Ranier Vilela <ranier.vf@gmail.com> writes:
> Em qui., 11 de fev. de 2021 às 01:46, Tom Lane <tgl@sss.pgh.pa.us> escreveu:
>> At the same time, I think this code could be improved; but the way
>> to do that is to use strtoint(), rather than kluging the choice of
>> datatype even further.

> No matter the function used strtol or strtoint, push_path will remain
> broken with Windows 64bits.

There is quite a lot of difference between "broken" and "my compiler
generates pointless warnings".  Still, I changed it to use strtoint(),
because that's simpler and better style.

			regards, tom lane



Commits

  1. Simplify jsonfuncs.c code by using strtoint() not strtol().