Horton

Re: SerializeParamList vs machines with strict alignment

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, hlinnaka <hlinnaka@iki.fi>
Date: 2018-10-02T18:55:29Z
Lists: pgsql-hackers 
Amit Kapila <amit.kapila16@gmail.com> writes:
>> Okay, I have pushed the test case patch on HEAD.  Attached is the
>> code-fix patch, let's wait for a day so that we have all the results
>> which can help us to discuss the merits of this patch.

> By now, the added test has failed on gharial [1] with below log on the server:

Yeah, gharial and anole both don't like this, which is interesting
but not really surprising, considering that IA64 is in some part
an HPPA follow-on architecture.  What I find more interesting is
that both of the live Sparc critters are happy --- so despite
Thomas' statements upthread, they're coping with unaligned accesses.
Maybe you should have back-patched the test to older branches so
we could see what castoroides and protosciurus would do.  But it's
probably not worth additional delay.

			regards, tom lane

Commits

  1. MAXALIGN the target address where we store flattened value.

  2. Test passing expanded-value representations to workers.