Horton

Re: Cleanup/remove/update references to OID column

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>, Daniel Verite <daniel@manitou-mail.org>, pgsql-hackers@lists.postgresql.org
Date: 2019-07-01T16:13:11Z
Lists: pgsql-hackers 
Justin Pryzby <pryzby@telsasoft.com> writes:
> I'm resending this patch, which still seems to be needed.

Yeah, clearly one copy of that text got missed out.  Pushed that.

> Also, should this be removed ?  Or at leat remove the parenthesized text, since
> non-system tables no longer have OIDs: "(use to avoid output on system tables)"

No, I think that's still fine as-is.  Tables still have OIDs, they
just don't *contain* magic OID columns.

> And maybe this (?)
> trace_lock_table (integer)

Hm, the description of that isn't English, at least:

			gettext_noop("Sets the OID of the table with unconditionally lock tracing."),

I'm not entirely sure about the point of tracing locks on just one
table, which seems to be what this is for.

			regards, tom lane

Commits

  1. Doc: remove obsolete description of oid column as being "hidden".

  2. docs: Fix small copy & paste mistake.

  3. pg_dump: Remove stray option parsing support for -o.

  4. docs: cleanup/remove/update references to OID column.

  5. Adjust some more comments for WITH OIDS removal.

  6. Doc: remove obsolete statements about system OID columns in ALTER TABLE.