Re: An example of bugs for Hot Standby
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Simon Riggs <simon@2ndquadrant.com>, Hiroyuki Yamada <yamada@kokolink.net>
Date: 2010-01-20T16:59:36Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > I realize its way too late in the cycle for that, but why dont we start using > some library for easy cross platform atomic ops? (1) there probably isn't one that does exactly what we want, works everywhere, and has the right license; (2) what actual gain would we get? We've already done the work. >> [ grows visibly pale ] *Please* tell me we are not trying to take >> locks in a signal handler. What happens if it interrupts code that >> is already holding that lock? > Yes the patch does that at two places. That's a must-fix. regards, tom lane