Re: pgsql: Integrate recovery.conf into postgresql.conf

Sergei Kornilov <sk@zsrv.org>

From: Sergei Kornilov <sk@zsrv.org>

To: Stephen Frost <sfrost@snowman.net>

Cc: Michael Paquier <michael@paquier.xyz>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Postgres hackers <pgsql-hackers@postgresql.org>

Date: 2018-11-26T18:34:38Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Integrate recovery.conf into postgresql.conf
- 2dedf4d9a899 12.0 cited

Hello

> I think I would have done 'if (targetSettingsCount != 1)' here.
Streaming replication does not have any recovery_target.
Well, i can check StandbyModeRequested too and allow 0 recovery_target only for standby mode.

>>  -# Multiple targets
>>  -# Last entry has priority (note that an array respects the order of items
>>  -# not hashes).
>
> You could (and imv should) include a test that throws an expected error
> if multiple targets are specified.
We have some example for checking unable-to-start DB? Did not find yet

> Let’s at least fix the currently committed patch before adding new features or changing how things in recovery work.
+1

regards, Sergei