Re: Improve hash join's handling of tuples with null join keys

Chao Li <li.evan.chao@gmail.com> writes:
> Overall, this looks like a solid patch to me.

Thanks for taking another look.

> The only thing I noticed is that while 0002 fixes the tuple-counting issue, there does not seem to be a test that would fail without it. So I think it would be better to add a test case for 0002. I tried doing that and attached a diff. Without 0002, the test fails; with 0002, it passes.

I couldn't get excited about expending test cycles on that.

			regards, tom lane