Re: Attempt to consolidate reading of XLOG page

Antonin Houska <ah@cybertec.at>

From: Antonin Houska <ah@cybertec.at>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-07-09T10:15:37Z

Lists: pgsql-hackers

Attachments

v04-0001-Make-XLogReaderInvalReadState-static.patch (text/x-diff)

Thomas Munro <thomas.munro@gmail.com> wrote:

> On Tue, May 21, 2019 at 9:12 PM Antonin Houska <ah@cybertec.at> wrote:
> > Robert Haas <robertmhaas@gmail.com> wrote:
> > > It seems to me that it's better to unwind the stack i.e. have the
> > > function return the error information to the caller and let the caller
> > > do as it likes.
> >
> > Thanks for a hint. The next version tries to do that.
> 
> Hi Antonin,
> 
> Could you please send a fresh rebase for the new Commitfest?

Rebased.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com

Commits

Remove logical_read_local_xlog_page
- 5d0c2d5eba6b 13.0 landed
Refactor WAL file-reading code into WALRead()
- 0dc8ead46363 13.0 landed
Rework WAL-reading supporting structs
- 709d003fbd98 13.0 landed
Make XLogReaderInvalReadState static
- 25dcc9d35dfe 13.0 landed
Use pg_pread() and pg_pwrite() for data files and WAL.
- c24dcd0cfd94 12.0 cited