Horton

Re: Misleading comment in tuplesort_set_bound

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: James Coleman <jtc331@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-09-12T14:00:31Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> [ shrug ]  It seemed to require no further work, so I just pushed Tom's
> proposed change.
> I added an empty line after the new combined assertion, which makes
> clearer (to me anyway) that the other assertions are unrelated.

Actually, the thing I wanted to add was some actual comments for
those other assertions.  But that requires a bit of research that
I hadn't made time for...

			regards, tom lane

Commits

  1. Make tuplesort_set_bound() assertions more comprehensible, hopefully.

  2. Merge two assertions to make comment clearer