Horton

Re: headerscheck warnings with late-model gcc

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-08-06T19:11:36Z
Lists: pgsql-hackers 
Peter Eisentraut <peter@eisentraut.org> writes:
> On 05.08.25 20:09, Tom Lane wrote:
>> Curiously, no such complaints appear with cpluspluscheck (which is
>> using g++ 15.1.1).  I don't really understand why not ...

> -Wmissing-variable-declarations is added by us as of PG18 (commit 
> 66188912566).  It's available since gcc 14 and doesn't exist for C++.

Oh!  Okay, that explains the lack of messages, but it still seems
like an odd omission.

			regards, tom lane

Commits

  1. Silence -Wmissing-variable-declarations in headerscheck.

  2. headerscheck: Document that --with-llvm is required

  3. headerscheck: Ignore Windows-specific header

  4. headerscheck: Use ICU_CFLAGS

  5. Add -Wmissing-variable-declarations to the standard compilation flags