Re: PL/Python result set slicing broken in Python 3
Peter Eisentraut <peter_e@gmx.net>
From: Peter Eisentraut <peter_e@gmx.net>
To: Jan Urbański <wulczer@wulczer.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-05-10T17:45:00Z
Lists: pgsql-hackers
On lör, 2012-05-05 at 22:45 +0200, Jan Urbański wrote: > Apparently once you implement PyMappingMethods.mp_subscript you can > drop PySequenceMethods.sq_slice, but I guess there's no harm in > keeping it (and I'm not sure it'd work on Python 2.3 with only > mp_subscript implemented). Committed this now. From test coverage reports, I now see that PLy_result_ass_item() is no longer called. That's probably OK, if assignments are now handled through the mapping methods. But should we remove the function then? > > Do we want to backpatch this? If so, I'd need to produce a version > that applies to the monolithic plpython.c file from the previous > releases. I don't think this should be backpatched.