Horton

Re: [COMMITTERS] pgsql: Add new keywords SNAPSHOT and TYPES to the keyword list in gram.

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2012-02-09T18:30:27Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add new keywords SNAPSHOT and TYPES to the keyword list in gram.y

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Excerpts from Tom Lane's message of jue feb 09 12:17:59 -0300 2012:
>> If people are sufficiently worried about this, a better answer would be
>> to teach the makefiles to run check_keywords.pl during every build.

> FWIW that script is throwing a warning here:
> Use of assignment to $[ is deprecated at /pgsql/source/HEAD/src/tools/check_keywords.pl line 19.

Any Perl hackers want to improve that script?

> Also, we should at least do the attached to simplify the process.
> +check:
> +	$(top_srcdir)/src/tools/check_keywords.pl $(top_srcdir)

Actually, what would make sense in that line is to attach it to the
existing maintainer-check target, no?  I don't think top-level
"make check" descends into this directory.

			regards, tom lane