Horton

Re: SerializeParamList vs machines with strict alignment

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, hlinnaka <hlinnaka@iki.fi>
Date: 2018-10-02T04:08:06Z
Lists: pgsql-hackers 
Amit Kapila <amit.kapila16@gmail.com> writes:
> On Tue, Oct 2, 2018 at 9:22 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (I think we could drop the savepoint
>> too, no?)

> One advantage of keeping the savepoint is that we don't need to
> explicitly drop the objects which we have created temporarily for this
> test.

They'll go away anyway at the end of the transaction that the whole
script is wrapped in.  (But it might be worth choosing slightly less
generic object names, to avoid a conflict against other sub-tests
later in that script.)

			regards, tom lane

Commits

  1. MAXALIGN the target address where we store flattened value.

  2. Test passing expanded-value representations to workers.