Re: Another review of URI for libpq, v7 submission

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>

To: Alex <ash@commandprompt.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2012-03-27T17:22:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Refactor to eliminate duplicate copies of conninfo default-finding code.
- e9ce658b6203 9.2.0 cited

Attachments

libpq-uri-v9+petere.patch (text/x-patch) patch

On tor, 2012-03-22 at 23:42 +0200, Alex wrote:
> Okay, at last here's v9, rebased against current master branch.

Attached is a patch on top of your v9 with two small fixes:

- Don't provide a check target in libpq/Makefile if it's not
implemented.

- Use the configured port number for running the tests (otherwise it
runs against my system installation, for example).