Horton

Re: xlog location arithmetic

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Magnus Hagander <magnus@hagander.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Fujii Masao <masao.fujii@gmail.com>, Euler Taveira de Oliveira <euler@timbira.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2012-03-09T19:23:28Z
Lists: pgsql-hackers 
On fre, 2012-03-09 at 18:13 +0100, Magnus Hagander wrote:
> > and confusing XLogFileSize with XLogSegSize.  Not the best choice of
> > names.
> 
> Yeah, the use of XLogFile to mean something other than, well a file in
> the xlog, is greatly annoying.. I guess we could change it, but it
> goes pretty deep in the system so it's not a small change...
> 
The whole thing was built around the lack of 64 bit integers.  If we bit
the bullet and changed the whole thing to be just a single 64-bit
counter, we could probably delete thousands of lines of code.