Horton

Re: review: CHECK FUNCTION statement

Alvaro Herrera <alvherre@commandprompt.com>

View thread
From: Alvaro Herrera <alvherre@commandprompt.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Petr Jelínek <pjmodos@pjmodos.net>, Greg Smith <greg@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Albe Laurenz <laurenz.albe@wien.gv.at>
Date: 2012-03-03T20:56:23Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add const qualifiers to node inspection functions

Excerpts from Alvaro Herrera's message of sáb mar 03 16:54:19 -0300 2012:
> Excerpts from Pavel Stehule's message of sáb mar 03 02:25:52 -0300 2012:

> > 3. THE ARE NOT CARET - this is really important

> I am not sure about the caret thingy -- mainly because I don't think it
> works all that well.  I don't know how psql does it, but I notice that
> it shows a single line in a multiline query -- so it's not just a matter
> of adding some number of spaces.

I checked how this works in psql.  It is upwards of 200 lines of code --
see reportErrorPosition in libpq/fe-protocol3.c.  I'm not sure this can
be made to work sensibly here.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support