Horton

Re: review of: collation for (expr)

Peter Eisentraut <peter_e@gmx.net>

View thread
From: Peter Eisentraut <peter_e@gmx.net>
To: Jaime Casanova <jaime@2ndquadrant.com>
Cc: probabble <probabble@gmail.com>, pgsql-hackers@postgresql.org
Date: 2012-03-02T19:20:06Z
Lists: pgsql-hackers 
On tor, 2012-03-01 at 20:30 -0500, Jaime Casanova wrote:
> besides a clash in the oid and the value of leakproof missing in the
> pg_proc entry, everything works fine.

Fixed.

> The only thing is that i don't see a reason for these includes in
> src/backend/utils/adt/misc.c:
> 
> + #include "nodes/nodeFuncs.h"
> + #include "utils/lsyscache.h"

lsyscache.h is necessary for type_is_collatable(), but the other was
probably left over from a previous attempt.

Committed with these changes.