Horton

Re: Use \if/\endif to remove non-libxml2 expected output in regression tests

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-15T00:56:29Z
Lists: pgsql-hackers 
Michael Paquier <michael@paquier.xyz> writes:
> Okay.  So fusioning my stuff, your stuff and Daniel's comment
> suggestion, I get the attached.  That's working here with my system's
> libxml2 (2.12.10), libxml2 2.9.3 and without libxml2.

> Does that look right?  

Locally, I'd changed the line

+INSERT INTO xmltest VALUES (3, '<value>two</wrong>  ');

to be

+INSERT INTO xmltest VALUES (3, '<value>three</wrong>  ');

after sending my 1.0 patch; it was basically a copy-and-paste
error that it wasn't "three" already.  That would have follow-on
effects in xml.out and xml_1.out, so if you don't feel like
adopting it, I won't complain hard.  No other suggestions.

			regards, tom lane

Commits

  1. Trim regression test expected output for xml

  2. Add an expected-file to match behavior of latest libxml2.