Re: REASSIGN OWNED lacks support for FDWs

Alvaro Herrera <alvherre@commandprompt.com>

From: Alvaro Herrera <alvherre@commandprompt.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Robert Haas <robertmhaas@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2012-02-21T22:14:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add missing support for removing foreign data wrapper / server privileges
- e356743f3ed4 9.1.0 cited

Attachments

reassign-fdw.patch (application/octet-stream) patch

Excerpts from Alvaro Herrera's message of mar feb 21 15:54:03 -0300 2012:
> Excerpts from Tom Lane's message of lun feb 20 12:37:45 -0300 2012:
> > Robert Haas <robertmhaas@gmail.com> writes:
> > > On Wed, Feb 15, 2012 at 12:58 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >> As per http://archives.postgresql.org/pgsql-general/2012-02/msg00304.php
> > >> there is no switch case in shdepReassignOwned for foreign data wrappers.

> I'm gonna take a stab at fixing this now (the simple way).

Here's the patch I have; last minute opinions.  I intend to push a
backpatch to 9.1 and 9.0.  8.4 has the same problem, but since Heikki
punted in e356743f3ed45c36dcc4d0dbf6c1e8751b3d70b5, I'm not going to
bother either.

-- 
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support