Re: hiding variable-length fields from Form_pg_* structs

Peter Eisentraut <peter_e@gmx.net>

View thread

From: Peter Eisentraut <peter_e@gmx.net>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>

Date: 2012-01-26T18:01:21Z

Lists: pgsql-hackers

Attachments

catalog-varlen.patch (text/x-patch) patch

On mån, 2012-01-09 at 14:04 -0500, Tom Lane wrote:
> #ifdef CATALOG_VARLEN           /* variable-length fields start here
> */
> 
> to be even clearer.
> 
> What would be appropriate to add instead of those inconsistently-used
> comments is explicit comments about the exception cases such as
> proargtypes, to make it clear that the placement of the #ifdef
> CATALOG_VARLEN is intentional and not a bug in those cases.
> 
I implemented your suggestions in the attached patch.