Horton

Thread

  1. psql case preserving completion

    Peter Eisentraut <peter_e@gmx.net> — 2012-01-11T20:29:18Z

    In psql, the tab completion always converts key words to upper case.  In
practice, I and I think most users type in lower case.  So then you end
up with commands looking like this:

=> alter TABLE foo add CONSTRAINT bar check (a > 0);

To address this, I have implemented a slightly different completion mode
that looks at the word being completed and converts the completed word
to the case of the original word.  (Well, it looks at the first letter.)

In fact, since almost all completions in psql are of this nature, I made
this the default mode for COMPLETE_WITH_CONST and COMPLETE_WITH_LIST and
added a new macro COMPLETE_WITH_LIST_CS that uses the old case-sensitive
behavior. The latter is used mainly for completing backslash commands.

After playing with this a little, I find the behavior more pleasing.
Less yelling. ;-)

Patch attached.

  2. Re: psql case preserving completion

    Pavel Stehule <pavel.stehule@gmail.com> — 2012-01-11T20:35:03Z

    2012/1/11 Peter Eisentraut <peter_e@gmx.net>:
> In psql, the tab completion always converts key words to upper case.  In
> practice, I and I think most users type in lower case.  So then you end
> up with commands looking like this:
>
> => alter TABLE foo add CONSTRAINT bar check (a > 0);
>
> To address this, I have implemented a slightly different completion mode
> that looks at the word being completed and converts the completed word
> to the case of the original word.  (Well, it looks at the first letter.)
>
> In fact, since almost all completions in psql are of this nature, I made
> this the default mode for COMPLETE_WITH_CONST and COMPLETE_WITH_LIST and
> added a new macro COMPLETE_WITH_LIST_CS that uses the old case-sensitive
> behavior. The latter is used mainly for completing backslash commands.
>
> After playing with this a little, I find the behavior more pleasing.
> Less yelling. ;-)
>
> Patch attached.

+1

Pavel

>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

  3. Re: psql case preserving completion

    Fujii Masao <masao.fujii@gmail.com> — 2012-01-17T07:46:07Z

    On Thu, Jan 12, 2012 at 5:29 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> In psql, the tab completion always converts key words to upper case.  In
> practice, I and I think most users type in lower case.  So then you end
> up with commands looking like this:
>
> => alter TABLE foo add CONSTRAINT bar check (a > 0);
>
> To address this, I have implemented a slightly different completion mode
> that looks at the word being completed and converts the completed word
> to the case of the original word.  (Well, it looks at the first letter.)
>
> In fact, since almost all completions in psql are of this nature, I made
> this the default mode for COMPLETE_WITH_CONST and COMPLETE_WITH_LIST and
> added a new macro COMPLETE_WITH_LIST_CS that uses the old case-sensitive
> behavior. The latter is used mainly for completing backslash commands.
>
> After playing with this a little, I find the behavior more pleasing.
> Less yelling. ;-)
>
> Patch attached.

When I tested the patch, "create ta" was converted unexpectedly to
"create TABLE"
though "alter ta" was successfully converted to "alter table". As far
as I read the patch,
you seems to have forgotten to change create_or_drop_command_generator() or
something.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  4. Re: psql case preserving completion

    Peter Eisentraut <peter_e@gmx.net> — 2012-02-01T18:19:24Z

    On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote:
> When I tested the patch, "create ta" was converted unexpectedly to
> "create TABLE"
> though "alter ta" was successfully converted to "alter table". As far
> as I read the patch,
> you seems to have forgotten to change create_or_drop_command_generator() or
> something.

Thanks, fixed and committed.

  5. Re: psql case preserving completion

    Bruce Momjian <bruce@momjian.us> — 2012-02-08T01:02:21Z

    On Wed, Feb 01, 2012 at 08:19:24PM +0200, Peter Eisentraut wrote:
> On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote:
> > When I tested the patch, "create ta" was converted unexpectedly to
> > "create TABLE"
> > though "alter ta" was successfully converted to "alter table". As far
> > as I read the patch,
> > you seems to have forgotten to change create_or_drop_command_generator() or
> > something.
> 
> Thanks, fixed and committed.

I have to admit I like the capitalized keywords, but don't normally type
them, but it must be just me because no one else said anything.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

  6. Re: psql case preserving completion

    Robert Haas <robertmhaas@gmail.com> — 2012-02-08T02:50:21Z

    On Tue, Feb 7, 2012 at 8:02 PM, Bruce Momjian <bruce@momjian.us> wrote:
> On Wed, Feb 01, 2012 at 08:19:24PM +0200, Peter Eisentraut wrote:
>> On tis, 2012-01-17 at 16:46 +0900, Fujii Masao wrote:
>> > When I tested the patch, "create ta" was converted unexpectedly to
>> > "create TABLE"
>> > though "alter ta" was successfully converted to "alter table". As far
>> > as I read the patch,
>> > you seems to have forgotten to change create_or_drop_command_generator() or
>> > something.
>>
>> Thanks, fixed and committed.
>
> I have to admit I like the capitalized keywords, but don't normally type
> them, but it must be just me because no one else said anything.

Yeah, I liked the old behavior, too.  But I figured it was a sign that
I'm an old fuddy-duddy.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company