Re: hiding variable-length fields from Form_pg_* structs

Peter Eisentraut <peter_e@gmx.net>

From: Peter Eisentraut <peter_e@gmx.net>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Date: 2012-01-09T18:47:35Z
Lists: pgsql-hackers

Attachments

So here is a patch for that.

There are a few cases that break when hiding all variable length fields:

Access to indclass in relcache.c, as discussed upthread, which should be
fixed.

Access to pg_largeobject.data.  This is apparently OK, per comment in
inv_api.c.

Access to pg_proc.proargtypes in various places.  This is clearly
useful, so we'll keep it visible.

So I think the relcache.c thing should be fixed and then this might be
good to go.