Horton

Re: Error while copying a large file in pg_rewind

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-07-03T13:53:35Z
Lists: pgsql-hackers 
Kuntal Ghosh <kuntalghosh.2007@gmail.com> writes:
> pg_rewind throws the following error when there is a file of large
> size available in the Slave server's data directory.

Hm.  Before we add a bunch of code to deal with that, are we sure we
*want* it to copy such files?  Seems like that's expending a lot of
data-transfer work for zero added value --- consider e.g. a server
with a bunch of old core files laying about in $PGDATA.  Given that
it's already excluded all database-data-containing files, maybe we
should just set a cap on the plausible size of auxiliary files.

			regards, tom lane

Commits

  1. pg_rewind: Fix some problems when copying files >2GB.

  2. pg_rewind: Fix busted sanity check.

  3. Code review for 64-bit-large-object patch.