Horton

Re: [BUGS] Postgresql on Ultraparc/Linux , Bug report and patch!

Tom Lane <tgl@sss.pgh.pa.us>

View thread
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Silvio Macedo <smacedo@ic.ac.uk>
Cc: bugs@postgreSQL.org
Date: 1999-11-25T16:08:57Z
Lists: pgsql-bugs 
Silvio Macedo <smacedo@ic.ac.uk> writes:
> In src/backend/utils/adt/name.c you do:
>     return (bool) strncmp(arg1->data, arg2->data, NAMEDATALEN) == 0;
> In this way you are casting strncmp to bool, and not the comparison.

Oops.  Good catch!

Wonder if there are similar mistakes elsewhere?  If so, how could we
find them?

			regards, tom lane